Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/761#issuecomment-136321979
  
    Just discussed with @remibergsma and went over the old (4.4) code, the 
change made by @rajesh-battala  - which broke the behaviour - and how 4.6 now 
is. The change LGTM concerning the hotfix on 4.4.
    
    In terms of future proof fix, would be nice to have a massive tests on all 
the investigators and get rid of those things returning null instead of a 
boolean.
    
    Cheers,
    Wilder


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to