Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/784#discussion_r39248790
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py ---
@@ -95,9 +95,25 @@ def get_control_if(self):
return ip
return None
+ def check_if_link_exists(self,dev):
+ cmd="ip link show dev %s"%dev
+ result=CsHelper.execute(cmd)
+ if(len(result)!=0):
+ return True
+ else:
+ return False
+
+ def check_if_link_up(self,dev):
+ cmd="ip link show dev %s | tr '\n' ' ' | cut -d ' ' -f 9"%dev
--- End diff --
We should keep as much logic in Python as possible. The performance
difference is small, but with tr and grep you spawn subprocessess again.
But as @remibergsma says. Try to open that file in /sys and parse the
contents. You can use the simple Python file functions.
No need to execute IP. The less subprocesses we execute, the better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
