Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/800#discussion_r39263080
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDatabag.py ---
@@ -130,7 +136,10 @@ def get_router_password(self):
This is slightly difficult to happen, but if it does, destroy the
router with the password generated with the
code below and restart the VPC with out the clean up option.
'''
- passwd = "%s-%s" % (self.get_vpccidr, self.get_router_id())
+ if(self.get_type()=='router'):
--- End diff --
- run pep8, fix errors
- consider using -- if self.get_type() == "router" or if
self.get_type() is "router"
- stick to uniform usage to quotes, double quotes for strings here so
"router" instead of 'router'
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
