On 11-09-15 16:26, Remi Bergsma wrote: > Hi all, > > What happened to master? I see a lot of direct commits. I thought we agreed > to make a PR, then _merge_ it to master with the script in ./tools/git/git-pr. >
Errr, I used that script? This is what my Bash history shows me: wido@wido-desktop:~/repos/cloudstack$ history |grep git-pr 1752 ./tools/git/git-pr https://github.com/apache/cloudstack/pull/757 2013 ./tools/git/git-pr https://github.com/apache/cloudstack/pull/783 2025 ./tools/git/git-pr https://github.com/apache/cloudstack/pull/794 2027 ./tools/git/git-pr https://github.com/apache/cloudstack/pull/807 2029 ./tools/git/git-pr https://github.com/apache/cloudstack/pull/795 2030 ./tools/git/git-pr https://github.com/apache/cloudstack/pull/784 2043 history |grep git-pr wido@wido-desktop:~/repos/cloudstack$ They all had 2 LGTM, so I merged them. Any idea what went wrong here? > We’re getting ready for a 4.6 RC and this makes stuff extra hard to track. > Most direct commits seem to come from PRs, but I don’t think all of them did. > > Talking about this (there are more): > https://github.com/apache/cloudstack/commit/b66dcda49f370e6fc91ebff889a694f17826ca44 > https://github.com/apache/cloudstack/commit/1c6378ec0056e8c75990a4a0c15e99b2df162a75 > https://github.com/apache/cloudstack/commit/1a02773b556a0efa277cf18cd099fc62a4e27706 > https://github.com/apache/cloudstack/commit/ba59a43333b6f31e48e4b6e43e16068e4cacdc45 > https://github.com/apache/cloudstack/commit/f661ac0a2a783447b6eaab590d58091ec542aec2 > > Please don’t make me revert the direct commits. > > If you need help with getting PRs merged, ping me or Rajani as we’re happy to > help. > > Thanks, > Remi >
