Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/828#discussion_r39597202 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java --- @@ -598,6 +601,19 @@ public static void setBasicVmConfig(VirtualMachineConfigSpec vmConfig, int cpuCo vmConfig.setGuestId(guestOsIdentifier); } + public static void addUSBController(VirtualMachineConfigSpec vmConfigSpec) { --- End diff -- While it's alright, you can make this method `addUSBController ` return something rather than modify the passed in VirtualMachineConfigSpec, and add a small unit test.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---