[GitHub] cloudstack pull request: Removal of DefaultUserAuthenticator empty...

[rafaelweingartner]

Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/852#issuecomment-141721291
  
    Nice work @alexandrelimassantana, the class “DefaultUserAuthenticator” 
does not bring anything new to the hierarchy. Moreover, it has a comment “Use 
this UserAuthenticator if users are already authenticated outside”, but it is 
an abstract class, there is no way to use that class the way it is. That class 
seems something that was left behind a long time ago.
    
    I would just add, could you remove the @Local annotations on classes that 
you touched? They are not needed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---