Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/829#issuecomment-142906721
This is perfectly clear to me. The problem is we are relaying on the
`update_time` (not to mix up with `power_state_update_time`).
~~~
*************************** 1. row ***************************
instance_name: r-2978-VM
type: DomainRouter
update_time: 2015-08-24 21:54:42
power_state_update_time: 2015-09-09 08:30:42
power_state_update_count: 3
1 row in set (0.00 sec)
~~~
here
~~~java
// 2 times of sync-update interval for graceful period
long milliSecondsGracefullPeriod = PingInterval.value() * 2000L;
for (VMInstanceVO instance : vmsThatAreMissingReport) {
Date vmStateUpdateTime = instance.getUpdateTime();
//...
long milliSecondsSinceLastStateUpdate =
currentTime.getTime() - vmStateUpdateTime.getTime();
if (milliSecondsSinceLastStateUpdate >
milliSecondsGracefullPeriod) {
~~~
so this calculation would do this:
~~~
milliSecondsSinceLastStateUpdate = currentTime.getTime() -
vmStateUpdateTime.getTime()
2015-09-24 13:46:48 - 2015-08-24 21:54:42 ~= 1 month
if (1 month > 2 minutes grace period)
~~~
still the opinion, increasing grace period would help?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
