Can’t we not run the test if we do not wish to do so? \ Miguel Ferreira mferre...@schubergphilis.com<mailto:mferre...@schubergphilis.com>
On 01 Oct 2015, at 12:11, Koushik Das <koushik....@citrix.com<mailto:koushik....@citrix.com>> wrote: Can't we output a proper message (missing OR incorrect config) while skipping the test? On 01-Oct-2015, at 2:56 PM, Miguel Ferreira <mferre...@schubergphilis.com<mailto:mferre...@schubergphilis.com>> wrote: Hi Raja, I don’t agree with what you propose. I do understand your intention is to be able to run all tests and skip the ones you don’t have a config for. However, I also see the other side of that coin, when someone actually wants to run the tests but makes a mistake in the config and the tests get skipped. I think the test should fail if the config is not right, or otherwise be excluded if the indentation is to not run them. Cheers, \ Miguel Ferreira mferre...@schubergphilis.com<mailto:mferre...@schubergphilis.com><mailto:mferre...@schubergphilis.com> On 30 Sep 2015, at 19:40, Raja Pullela <raja.pull...@citrix.com<mailto:raja.pull...@citrix.com><mailto:raja.pull...@citrix.com>> wrote: Hi Miguel, Can you please add some checking in the setup method for the configuration parameters and if it is not available, can you skip this test? Raja -----Original Message----- From: Raja Pullela [mailto:raja.pull...@citrix.com] Sent: Wednesday, September 30, 2015 5:52 PM To: Miguel Ferreira <mferre...@schubergphilis.com<mailto:mferre...@schubergphilis.com><mailto:mferre...@schubergphilis.com>> Cc: dev <dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org><mailto:dev@cloudstack.apache.org>> Subject: RE: test_nicira_controller.py is failing on all Advzone - XS, KVM thanks Miguel ! From: Miguel Ferreira [mailto:mferre...@schubergphilis.com] Sent: Wednesday, September 30, 2015 3:01 PM To: Raja Pullela <raja.pull...@citrix.com<mailto:raja.pull...@citrix.com><mailto:raja.pull...@citrix.com>> Cc: dev <dev@cloudstack.apache.org<mailto:dev@cloudstack.apache.org><mailto:dev@cloudstack.apache.org>> Subject: Re: test_nicira_controller.py is failing on all Advzone - XS, KVM Hi Raja, That test needs a NSX cluster. With that in place, the configuration used to run the test must define a section called NiciraNvp, and that section should have an array os hosts with that name (see line 46 of the test). In a Marvin config that materializes in something like this: "niciraNvp": { "hosts": [ "nsxcon1.cloud.lan", "nsxcon2.cloud.lan" ] } Furthermore, you need to have a zone configured to use NSX and that requires more work. You can find a full Marvin config for it here: https://github.com/schubergphilis/MCT-shared/blob/master/marvin/mct-zone1-kvm1-NVP.cfg In that same git repo there are config files for deploying a NSX cluster (https://github.com/schubergphilis/MCT-shared/blob/master/deploy/cloud/nsx_cluster.conf). However, we have not yet fully automated all the steps needed to get the cluster up and running (ie. setting up the cluster internals, and adding a more controllers to the cluster). I can help you with that if you need. Cheers, \ Miguel Ferreira mferre...@schubergphilis.com<mailto:mferre...@schubergphilis.com><mailto:mferre...@schubergphilis.com><mailto:mferre...@schubergphilis.com> On 30 Sep 2015, at 09:05, Raja Pullela <raja.pull...@citrix.com<mailto:raja.pull...@citrix.com><mailto:raja.pull...@citrix.com><mailto:raja.pull...@citrix.com>> wrote: Hi Miguel or someone's familiar with this test, Can you please provide documentation around how to get these tests running ? BTW - looks like this is a new test that was added on Aug 25th 2015. Thanks, Raja === TestName: None | Status : EXCEPTION === ERROR ====================================================================== ERROR: test suite for <class 'integration.smoke.test_nicira_controller.TestNiciraContoller'> ---------------------------------------------------------------------- Traceback (most recent call last): File "/usr/local/lib/python2.7/dist-packages/nose/suite.py", line 209, in run self.setUp() File "/usr/local/lib/python2.7/dist-packages/nose/suite.py", line 292, in setUp self.setupContext(ancestor) File "/usr/local/lib/python2.7/dist-packages/nose/suite.py", line 315, in setupContext try_run(context, names) File "/usr/local/lib/python2.7/dist-packages/nose/util.py", line 470, in try_run return func() File "/root/cloudstack/test/integration/smoke/test_nicira_controller.py", line 46, in setUpClass cls.nicira_hosts = cls.config.niciraNvp.hosts AttributeError: 'NoneType' object has no attribute 'hosts' -------------------- >> begin captured stdout << --------------------- === TestName: None | Status : EXCEPTION === --------------------- >> end captured stdout << ---------------------- -------------------- >> begin captured logging << -------------------- CSLog: CRITICAL: EXCEPTION: None: ['Traceback (most recent call last):\n', ' File "/usr/local/lib/python2.7/dist-packages/nose/suite.py", line 209, in run\n self.setUp()\n', ' File "/usr/local/lib/python2.7/dist-packages/nose/suite.py", line 292, in setUp\n self.setupContext(ancestor)\n', ' File "/usr/local/lib/python2.7/dist-packages/nose/suite.py", line 315, in setupContext\n try_run(context, names)\n', ' File "/usr/local/lib/python2.7/dist-packages/nose/util.py", line 470, in try_run\n return func()\n', ' File "/root/cloudstack/test/integration/smoke/test_nicira_controller.py", line 46, in setUpClass\n cls.nicira_hosts = cls.config.niciraNvp.hosts\n', "AttributeError: 'NoneType' object has no attribute 'hosts'\n"] --------------------- >> end captured logging << --------------------- ---------------------------------------------------------------------- XML: /root/marvinxKcIvFqe/results.xml ---------------------------------------------------------------------- Ran 0 tests in 0.002s FAILED (errors=1)
