Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/901#issuecomment-144847280
  
    @karuturi Thanks a lot, works great! LGTM
    
    I registered a template with invalid headers, as per CLOUDSTACK-8808.
    
    At first everything is normal:
    <img width="715" alt="screen shot 2015-09-30 at 21 09 29" 
src="https://cloud.githubusercontent.com/assets/1630096/10233628/027aa5da-6890-11e5-97fc-981033df91f5.png";>
    
    It then starts installing (and unzipping):
    <img width="719" alt="screen shot 2015-09-30 at 21 11 22" 
src="https://cloud.githubusercontent.com/assets/1630096/10233631/0bdec520-6890-11e5-995e-f193691eb1e7.png";>
    
    And eventually disappears from the UI. The logs show `Format is invalid` as 
expected.
    
    Full logs:
    ```
    2015-10-01 20:55:00,624 WARN  [storage.template.TemplateLocation] 
(pool-1-thread-2:null) Format is invalid
    2015-10-01 20:55:00,625 DEBUG [storage.template.TemplateLocation] 
(pool-1-thread-2:null) Format: VHD size: 21475270656 virtualsize: 0 filename: 
4db55a50-1775-3f5d-b982-962eb2d0f282.vhd
    2015-10-01 20:55:00,625 DEBUG [storage.template.TemplateLocation] 
(pool-1-thread-2:null) format, filename cannot be null and size, virtual size 
should be  > 0 
    2015-10-01 20:55:02,241 DEBUG [storage.template.TemplateLocation] 
(pool-1-thread-2:null) Remove 
/mnt/SecStorage/6cc407de-bf89-3f72-8985-1b9df6a63827/template/tmpl/2/201/4db55a50-1775-3f5d-b982-962eb2d0f282.vhd
    2015-10-01 20:55:02,302 DEBUG [storage.template.TemplateLocation] 
(pool-1-thread-2:null) Remove 
/mnt/SecStorage/6cc407de-bf89-3f72-8985-1b9df6a63827/template/tmpl/2/201/template.properties
    
    2015-10-01 20:55:02,867 DEBUG [cloud.agent.Agent] 
(agentRequest-Handler-2:null) Processing command: 
org.apache.cloudstack.storage.command.DownloadProgressCommand
    2015-10-01 20:55:02,870 DEBUG [cloud.agent.Agent] 
(agentRequest-Handler-2:null) Seq 3-5925611209712730174:  { Ans: , MgmtId: 
90520732674659, via: 3, Ver: v1, Flags: 10, 
[{"com.cloud.agent.api.storage.DownloadAnswer":{"jobId":"d0965877-d8b8-4e12-a132-703fb7ee6b54","downloadPct":100,"errorString":"Failed
 post download script: Unable to install due to invalid file 
format","downloadStatus":"DOWNLOAD_ERROR","downloadPath":"/mnt/SecStorage/6cc407de-bf89-3f72-8985-1b9df6a63827/template/tmpl/2/201/dnld3817046421300354449tmp_","installPath":"template/tmpl/2/201/4db55a50-1775-3f5d-b982-962eb2d0f282.vhd","templateSize":0,"templatePhySicalSize":0,"checkSum":"49c737f858448e11eb181f250e4efaeb","result":true,"details":"Failed
 post download script: Unable to install due to invalid file 
format","wait":0}}] }
    ```
    
    When someone else reviews this we can merge it and solve another blocker.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to