Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/909#discussion_r41109279
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachinePowerStateSyncImpl.java ---
@@ -111,7 +111,19 @@ private void processReport(long hostId, Map<Long,
VirtualMachine.PowerState> tra
for (VMInstanceVO instance : vmsThatAreMissingReport) {
- Date vmStateUpdateTime = instance.getUpdateTime();
+ // Make sure powerState is up to date for missing VMs
+ try {
+ if
(!_instanceDao.isPowerStateUpToDate(instance.getId())) {
+ s_logger.warn("Detected missing VM but power state
is outdated, wait for another process report run for VM id: " +
instance.getId());
+
_instanceDao.resetVmPowerStateTracking(instance.getId());
+ continue;
+ }
+ } catch (CloudRuntimeException e) {
+ s_logger.warn("Checked for missing powerstate for none
existing vm", e);
--- End diff --
Can you correct the sentence to "Checked for missing powerstate of a non
existing vm"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
