Github user KrisSterckx commented on the pull request:

    https://github.com/apache/cloudstack/pull/801#issuecomment-145488778
  
    I would like to bring attention to the reviewers that only a few CS core 
extensions were made - all other modifications are NuageVsp plugin internal, 
for Nuage Virtualized Services Platform Release 3.2 support.
    
    api/src/com/cloud/network/Network.java
    * Remove the unused NuageVspVpc constant
    
    engine/schema/src/com/cloud/network/dao/IPAddressDao.java
    engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java
    * new DAO method added
    
    engine/schema/src/com/cloud/network/vpc/VpcOfferingVO.java
    * new constructor added
    
    server/src/com/cloud/configuration/ConfigurationManagerImpl.java
    * Exclude shared networks from DirectNetworkGuru canHandle() in case the 
offering is NuageVsp as then NuageVsp guru is handling.
    
    server/src/com/cloud/configuration/ConfigurationManagerImpl.java
    * Add extra check on isPersistent() for nuageVpc check


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to