Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r41778623
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -447,13 +568,95 @@ protected boolean applyACLRules(Network network,
List<? extends InternalIdentity
}
} catch (Exception e1) {
--- End diff --
Why are all checked and unchecked exceptions being caught here? Why not
catch the subset of expected checked exceptions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
