GitHub user cristofolini opened a pull request:
https://github.com/apache/cloudstack/pull/942
Removed unused code from the EngineHostDao Implementation
After analysing the code within the EngineHostDaoImpl class, we noticed
that methods:
countBy;
findByGuid;
findAndUpdateDirectAgentToLoad;
findAndUpdateApplianceToLoad;
markHostsAsDisconnected;
listAllUpAndEnabledNonHAHosts;
findLostHosts;
getRunningHostCounts;
getNextSequence;
countRoutingHostsByDataCenter;
updateResourceState;
findByTypeNameAndZoneId;
findHypervisorHostInCluster;
lockOneRandomRow;
And variables:
status_logger;
state_logger;
_resourceStateAttr
Have no usage. Thus, in order to clean up the code, we decided to remove
them from EngineHostDaoImpl and its interface (EngineHostDao).
All of EngineHostDaoImpl's attributes were set to private, given that they
are not accessed by any other class.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rafaelweingartner/cloudstack
lrg-cs-hackday-011
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/942.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #942
----
commit f1ec0c5ad14d81bdebbbfa195fc1c6418c69b675
Author: lucas <lucas@localhost.localdomain>
Date: 2015-10-17T19:33:12Z
Removed unused code from the EngineHostDao Implementation
(EngineHostDaoImpl)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
