Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-149018797
@nvazquez Thanks for your work on the commits, they are much better now. I
would say it can easily be improved even further, but given the current
practice in the project, it is already good!
As @remibergsma pointed out, it would be best if you apply your changes to
master. However if you want to use the functionality you added in a new minor
version of an older release, then make a PR for the branch of that release, and
we will help you port your changes all the way up to master. We have worked on
a workflow that helps with that
(https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+principles+for+Apache+CloudStack+4.6+and+up#ReleaseprinciplesforApacheCloudStack4.6andup-Whymergingforwardovercherry-pickingfrommaster?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
