Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/959#issuecomment-149882720
@wilderrodrigues @remibergsma @karuturi I tested the PR AS-IS, without the
changes proposed Wilder.
Test results:
```
=== TestName: test_03_ssvm_internals | Status : SUCCESS ===
ok
=== TestName: test_04_cpvm_internals | Status : SUCCESS ===
ok
=== TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
=== TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
=== TestName: test_07_reboot_ssvm | Status : SUCCESS ===
ok
=== TestName: test_08_reboot_cpvm | Status : SUCCESS ===
ok
=== TestName: test_09_destroy_ssvm | Status : SUCCESS ===
ok
=== TestName: test_10_destroy_cpvm | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 8 tests in 1805.321s
OK
```
```
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL |
Status : SUCCESS ===
ok
=== TestName: test_02_redundant_VPC_default_routes | Status : SUCCESS ===
ok
=== TestName: test_01_VPC_nics_after_destroy | Status : SUCCESS ===
ok
=== TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
=== TestName: test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
=== TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
=== TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS
===
ok
=== TestName: test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS
===
ok
----------------------------------------------------------------------
Ran 8 tests in 5981.632s
OK
```
```
=== TestName: test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
=== TestName: test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
=== TestName: test_assign_and_removal_lb | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 3 tests in 659.437s
OK
```
Based on the tests: LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
