Github user sateesh-chodapuneedi commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/977#discussion_r42966249
  
    --- Diff: 
api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotFromVMSnapshotCmd.java
 ---
    @@ -0,0 +1,191 @@
    +// Licensed to the Apache Software Foundation (ASF) under one
    +// or more contributor license agreements.  See the NOTICE file
    +// distributed with this work for additional information
    +// regarding copyright ownership.  The ASF licenses this file
    +// to you under the Apache License, Version 2.0 (the
    +// "License"); you may not use this file except in compliance
    +// with the License.  You may obtain a copy of the License at
    +//
    +//   http://www.apache.org/licenses/LICENSE-2.0
    +//
    +// Unless required by applicable law or agreed to in writing,
    +// software distributed under the License is distributed on an
    +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +// KIND, either express or implied.  See the License for the
    +// specific language governing permissions and limitations
    +// under the License.
    +package org.apache.cloudstack.api.command.user.snapshot;
    +
    +import org.apache.cloudstack.api.APICommand;
    +import org.apache.cloudstack.api.ApiCommandJobType;
    +import org.apache.cloudstack.api.ApiConstants;
    +import org.apache.cloudstack.api.ApiErrorCode;
    +import org.apache.cloudstack.api.BaseAsyncCmd;
    +import org.apache.cloudstack.api.BaseAsyncCreateCmd;
    +import org.apache.cloudstack.api.Parameter;
    +import org.apache.cloudstack.api.ServerApiException;
    +import org.apache.cloudstack.api.response.SnapshotResponse;
    +import org.apache.cloudstack.api.response.VMSnapshotResponse;
    +import org.apache.cloudstack.context.CallContext;
    +import org.apache.log4j.Logger;
    +
    +import com.cloud.event.EventTypes;
    +import com.cloud.exception.InvalidParameterValueException;
    +import com.cloud.exception.PermissionDeniedException;
    +import com.cloud.exception.ResourceAllocationException;
    +import com.cloud.projects.Project;
    +import com.cloud.storage.Snapshot;
    +import com.cloud.user.Account;
    +import com.cloud.uservm.UserVm;
    +import com.cloud.vm.snapshot.VMSnapshot;
    +
    +@APICommand(name = "createSnapshotFromVMSnapshot", description = "Creates 
an instant snapshot of a volume from vm snapshot.", responseObject = 
SnapshotResponse.class)
    --- End diff --
    
    Can we choose if we want to take snapshot of specific volume from vm 
snapshot? This helps if VM (owner VM of VM snapshot) has multiple volumes along 
with ROOT volume and the specified VM snapshot image represents chains of 
snapshot images of each volume of the VM.
    Probably we should add volumeId parameter to this to identify the volume 
that needs to be backed up?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to