Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-151412595 @ustcweizhou I think we shouldn't want a enable/disable flag in the agent.properties, it should work for anybody. That we already have a lot of commands being executed doesn't mean we should add more. We should try to get rid of all of them. Executing subcommands limits you to only checking the exit-status, but proper exception handling isn't possible. We shouldn't introduce new cases of executing subcommands. This can be fixed by addings these features to libvirt-java and using them afterwards. Maybe @bhaisaab, @DaanHoogland and @remibergsma can chime in?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---