Github user milamberspace commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/941#discussion_r43433516
  
    --- Diff: ui/scripts/network.js ---
    @@ -6504,7 +6432,123 @@
                             }
                         }
                     }
    -            }
    +            },
    +            vpnuser: {
    +                        type: 'select',
    +                        title: 'VPN Users',
    +
    +                        listView: {
    +                        id: 'vpnUsers',
    +                        fields: {
    +                            username: { label: 'label.name' },
    +                            domain: { label: 'label.domain' },
    +                            state: { label: 'label.state',
    +                                indicator: {
    +                                    'Active': 'on',
    +                                }
    +                            }
    +                        },
    +                        dataProvider: function(args) {
    +                            var data = {};
    +                            listViewDataProvider(args, data);
    +                            $.ajax({
    +                                url: createURL('listVpnUsers'),
    +                                data: data,
    +                                dataType: 'json',
    +                                async: true,
    +                                success: function(data) {
    +                                    args.response.success({
    +                                        data: 
data.listvpnusersresponse.vpnuser
    +                                    });
    +                                }
    +                            });
    +                        },
    +                        actions:{
    +                            destroy: {
    +                                label: 'label.action.delete.user',
    +                                messages: {
    +                                    confirm: function(args) { return 'Are 
you sure you want to delete the VPN user'},
    --- End diff --
    
    Would be better to use a new localization key and put the text in 
messages.properties file. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to