Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/commit/2a2d4364e14903d51cdc3d3a7b4e2eb979a60445#commitcomment-14123387
In
services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java:
In
services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
on line 2664:
Why are all checked and runtime exceptions being caught and not rethrown?
Not only could this broad catch could lead to the system become unstable, but
it would catch and swallow the ``ConfigurationException`` being thrown in this
block. It seems appropriate to refactor to a multi-catch for the expected
checked exceptions. Also, should those exceptions be re-thrown? If not, the
log message be a ``WARN`` not ``DEBUG``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
