Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1021#discussion_r43898594
  
    --- Diff: server/src/com/cloud/api/ApiResponseGsonHelper.java ---
    @@ -27,30 +29,40 @@
     import com.google.gson.GsonBuilder;
     
     /**
    - * The ApiResonseGsonHelper is different from ApiGsonHelper - it 
registeres one more adapter for String type required for api response encoding
    + * The ApiResonseGsonHelper is different from ApiGsonHelper - it registers 
one more adapter for String type required for api response encoding
    --- End diff --
    
    We should upgrade gson before further expanding on this feature of it. 
Exlusion strategies have somewhat changed in version 2 in the sense that 
exclusion is cahced inside gson and a change in loglevel is not endorsed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to