GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/1057
Cwe 190
coverity warnings of this type adressed. Some where dismissed and maybe
with reason but it seemed possible to remove them and hence obligatory ;p
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaanHoogland/cloudstack CWE-190
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1057.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1057
----
commit 944e6eabdff9b01f8980277fbe5dda5228fa94ad
Author: Daan Hoogland <[email protected]>
Date: 2015-11-10T13:00:22Z
CID-1175714 casts before bit shift
commit a9e122c77227363f3f27dbea7d13b4110c07a96f
Author: Daan Hoogland <[email protected]>
Date: 2015-11-10T13:16:49Z
CID-1116485: cast cidr during bit shifting
and simple test included
commit 17849c3b4b66a96c32d7ed8fb713f763ef19ee39
Author: Daan Hoogland <[email protected]>
Date: 2015-11-10T13:40:24Z
CID-1116484 cast to long and use long as cidrsize type
and simpel test
commit 1559e351d2a56a33ee3d844ce4964e5c4420e439
Author: Daan Hoogland <[email protected]>
Date: 2015-11-10T13:54:52Z
CID-1116483 cidr to netmask bitshifts guarded with casts
and simple test
commit f04b68c99c2d112b83617be7d51ac351a1882254
Author: Daan Hoogland <[email protected]>
Date: 2015-11-10T15:18:52Z
CID-1116482 cidrToLong cleanup of bitshift problem
and some trivial testing
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
