Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1057#issuecomment-158434570
Hi @DaanHoogland,
Do not give up now, I really liked your PR.
Those errors can be easily explained. You changed the behavior of
com.cloud.utils.net.NetUtils.cidrToLong(String), instead of a null when
receiving empty Cidrs, the method now throws an exception. That is why some
error happened. To fix that is actually pretty easy, you just need to work on
methods âisNetowrkASubsetOrSupersetOfNetworkBâ,
âisNetworkAWithinNetworkBâ and âisNetworksOverlapâ.
I have created a PR for your branch, so you can get those changes and
reopen your PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
