Github user miguelaferreira commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1094#discussion_r46265732
  
    --- Diff: 
api/src/com/cloud/network/guru/NetworkGuruAdditionalFunctions.java ---
    @@ -0,0 +1,12 @@
    +package com.cloud.network.guru;
    +
    +import java.util.Map;
    +
    +public interface NetworkGuruAdditionalFunctions {
    --- End diff --
    
    Wound't it be possible to call these methods inside the `GuestNetworkGuru` 
methods?
    I mean, have `NiciraNvpGuestNetworkGuru` call `finalizeNetworkDesign` and 
`listAdditionalNicParams` within the methods that are already defined in 
NetworkGuru?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to