Github user miguelaferreira commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1094#discussion_r48029359
  
    --- Diff: tools/marvin/marvin/lib/base.py ---
    @@ -3876,7 +3876,12 @@ def add(cls, apiclient, services, physicalnetworkid,
             else:
                 cmd.transportzoneuuid = services['transportZoneUuid']
     
    -        return NiciraNvp(apiclient.addNiciraNvpDevice(cmd).__dict__)
    +        if l2gatewayserviceuuid:
    +            cmd.l2gatewayserviceuuid = l2gatewayserviceuuid
    +        else:
    +            cmd.l2gatewayserviceuuid = services['l2gatewayserviceuuid']
    --- End diff --
    
    There should be the possibility to create the device without the l2 gateway 
uuid. This construct forces one to exists. Please make sure you test of 
`services` has key `'l2gatewayserviceuuid'`before you retrieve it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to