Makes sense. I will add code to list vpn customer gateways and will check if the response contains the customer gateway or not.
On Tue, Jan 5, 2016 at 3:55 PM, DaanHoogland <g...@git.apache.org> wrote: > Github user DaanHoogland commented on a diff in the pull request: > > https://github.com/apache/cloudstack/pull/1308#discussion_r48831039 > > --- Diff: test/integration/component/test_vpc.py --- > @@ -2490,3 +2498,23 @@ def test_21_deploy_vm_with_gateway_ip(self): > "Failed to create VM with first ip address in the CIDR as > the vm ip" > ) > return > + > + @attr(tags=["advanced", "intervlan"], required_hardware="false") > + def test_22_vpn_customer_gw_with_hostname(self): > + """ > + Test to create vpn customer gateway with hostname > + instead of gateway ip address > + """ > + try: > + vpnGw = VpnCustomerGateway.create( > + self.apiclient, > + self.services["vpn_customer_gw"], > + name="test_vpn_customer_gw", > + gateway="GwWithHostName", > + cidrlist="10.1.0.0/16" > + ) > + self.cleanup.append(vpnGw) > + except Exception as e: > + self.fail("Creating vpn customer gateway with hostname\ > + Failed with error :%s" % e) > + return > --- End diff -- > > @sanju1010 shouldn't some assertion that the adding succeeded be added > here? If some programmer decides to silently ignore an error somewhere this > test becomes useless. > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > --- >
