Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1330#discussion_r49442629
  
    --- Diff: python/lib/cloudutils/serviceConfigServer.py ---
    @@ -138,9 +138,8 @@ def checkHostName():
             except:
                 pass
     
    -        self.syscfg.svo.stopService("cloudstack-management")
    -
             if self.syscfg.env.noStart == False:
    +            self.syscfg.svo.stopService("cloudstack-management")
    --- End diff --
    
    so if nostart is false (start is true ??) the service is stopped. Am I 
understanding this wrong? it seems like we don't want this here and not 
unconditionally either but only if nostart is true.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to