[GitHub] cloudstack pull request: SecurityGroupRulesCmd code cleanup

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/1287#issuecomment-172353941
  
    Thanks @rafaelweingartner. as for your last remark 
    ```
    Your code as always is great, I would just suggest some more improvement at 
the new method you created that is called “represent”, I believe the best 
name for the boolean variable should be something like, “shouldCompress” 
or” hasToCompress”. The name of the method does not sound descriptive to 
me, but if you guys are ok with it, I am too.
    ```
    maybe ```withCompression``` would have been better then ```compressed```. I 
think the phrase ``` represent(cidr,compressed)``` expresses quite elegantly 
what it does however. Wouldn't you say so?
    
    We should have the talk on javadocs some other time. I think javadoc tends 
to outdate.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---