[GitHub] cloudstack pull request: CLOUDSTACK-9236: Load Balancing Health Ch...

[remibergsma]

Github user remibergsma commented on the pull request:

    https://github.com/apache/cloudstack/pull/1338#issuecomment-172545747
  
    LGTM based on these tests:
    
    Situation before when not using Netscaler:
    
    ![screen shot 2016-01-18 at 15 37 
25](https://cloud.githubusercontent.com/assets/1630096/12394040/baae8bc6-bdf9-11e5-9443-23ff6f2c42cb.png)
    
    ![screen shot 2016-01-18 at 15 34 
47](https://cloud.githubusercontent.com/assets/1630096/12394036/b5cc0b38-bdf9-11e5-9fc2-c29197c504ee.png)
    
    ![screen shot 2016-01-18 at 15 34 
58](https://cloud.githubusercontent.com/assets/1630096/12394044/c048925c-bdf9-11e5-9188-b694f823332c.png)
    
    Basically, the button is displayed but throws an ugly message.
    
    After the fix in this PR the button is hidden:
    
    ![screen shot 2016-01-18 at 15 38 
46](https://cloud.githubusercontent.com/assets/1630096/12394060/cffca7f6-bdf9-11e5-9c87-7cc739f5cc8e.png)
    
    Didn't test if it shows when using Netscaler, as I don't have it in my test 
environment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---