Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1310#issuecomment-173350754
Thanks @cristofolini
I've tryied writing a marvin test for testing this feature which would be:
* Select (or create) a vm (id=XXXX) which is already running and stop it.
* For vm with id=XXXX do the following:
<code>INSERT INTO cloud.user_vm_details (vm_id, name, value) VALUES
('XXXX', 'mks.enable3d', 'true');</code>
<code>INSERT INTO cloud.user_vm_details (vm_id, name, value) VALUES
('XXXX', 'mks.use3dRenderer', 'automatic');</code>
<code>INSERT INTO cloud.user_vm_details (vm_id, name, value) VALUES
('XXXX', 'svga.autodetect', 'false');</code>
<code>INSERT INTO cloud.user_vm_details (vm_id, name, value) VALUES
('XXXX', 'svga.vramSize', 'ZZZZ');</code>
</code>
Where <code>ZZZZ</code> is the ram size in KB
* Start vm XXXX again
In previous behaviour, it all worked except vram size, which was always set
to 64MB, ignoring size <code>ZZZZ</code> provided. With this fix, vram size is
set to <code>ZZZZ</code> when provided.
I couldn't be able to write a marvin test which follows these steps,
however I wrote a unit test for this new method, which is only accessed through
<code>execute(StartCommand)</code> method.
Nicolas
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
