GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1370
Support jdk8 mvnupgrades
Was learning about JDK8, lambdas, streams etc today. Thought it would be a
good idea to get ACS codebase to latest mvn and jdk8. This is a WIP branch
pushed on ACS remote so feel free to push changes if you're a committer or send
PR.
Major changes:
- Moved to latest JDK8
- Moved to latest Maven 3.3.9 (-T threaded compilations appears faster)
- Upgraded several dependencies to latest minor versions (or major in few
cases)
What fails/unsupported or TODOs:
- Unit tests in cloud-server and few other places
- F5 plugin fails, tried to resolve the issue but I was unable to grok it
- Major spring framework version (that would be a lot of work on its own)
- Major servlet version changes
- Fix packaging, init.d/system.d JAVA_HOME paths
- Check ACS agents with JDK/JRE8 (kvm, cpvm, ssvm)
- Check and configure GC related changes wrt JRE7/JRE8 (in any configs, say
tomcat configs)
- Check agains compatibility guide:
http://www.oracle.com/technetwork/java/javase/8-compatibility-guide-2156366.html
What works:
- Compiling in -Dnoredist with -DskipTests to test if ACS codebase (minus
unit tests) worked (non-issue once we fix the failing unit tests)
- Deploy db worked
- Running the management server locally with Java8
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/cloudstack support-jdk8-mvnupgrades
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1370.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1370
----
commit 998c41337a7ae4141b001be5561e7d7c338517f3
Author: Rohit Yadav <[email protected]>
Date: 2016-01-27T00:05:05Z
cloudstack: Switch build toolchain, travis, docker to JDK8
Signed-off-by: Rohit Yadav <[email protected]>
commit c4ff013b997ea79a7aa8d8075ed4c0703e70e468
Author: Rohit Yadav <[email protected]>
Date: 2016-01-27T00:30:21Z
framework/quota: Fix checkstyle issue
Fixes a checkstyle issue for enums, breaks with newer checkstyle versions
Signed-off-by: Rohit Yadav <[email protected]>
commit bf8fbd36aa045a61e3fab08c8c7ca41056154928
Author: Rohit Yadav <[email protected]>
Date: 2016-01-27T00:41:02Z
maven: Upgrade dependency versions and maven 3.3.9
Skipped: (but upgraded to latest minor release)
- Major spring framework version
- Servlet version
- Embedded jetty version
- Mockito version (beta)
- Mysql lib minor version upgrade (breaks mysql-ha plugin)
Signed-off-by: Rohit Yadav <[email protected]>
commit 7d3fab4060346a25f5f6fd52e819cea255149ebd
Author: Rohit Yadav <[email protected]>
Date: 2016-01-27T00:31:06Z
plugins: Comment out F5, breaks with Java8
Comment out F5 plugin which breaks for an unresolved issue:
cloudstack/plugins/network-elements/f5/src/com/cloud/network/resource/F5BigIpResource.java
--> cannot access Stub
We should fix it once we can get an updated iControl.jar or get this issue
fixed
Signed-off-by: Rohit Yadav <[email protected]>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
