Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/1447#issuecomment-199337285
Hi @DaanHoogland.
I did a maven install (this executes the unit tests). Also, the PR has
passed in the Jenkins and the CI tests. However, I did not execute functional
tests (integration tests).
The analysis was done manually; basically, I saw that a method was not
using some of its parameters. After that, I checked that this method is an
implementation of an interface's method, then I checked all classes that
implement that interface (just one), then I analyzed all of the methods in that
interface to detect if any other had the same problem with unused parameters
and fixed it.
Ty.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
