Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1444#discussion_r57202601
--- Diff:
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java
---
@@ -484,6 +489,10 @@ public DomainBlockStats answer(final InvocationOnMock
invocation) throws Throwab
// IO traffic as generated by the logic above, must be greater
than zero
Assert.assertTrue(vmStat.getDiskReadKBs() > 0);
Assert.assertTrue(vmStat.getDiskWriteKBs() > 0);
+ // Memory limit of VM must be greater than zero
--- End diff --
I have no idea; this code is not mine. I just cherry-picked the commit
â92b99714a03c238bcda6ac0c7a57b44cf4890e65â and worked around the possible
runtime exception that it might cause.
I expected the code to be ok, giving that it had already received LGTMs and
it seemed that it was only reverted because of those points we lifted up in the
PR #780.
The code I introduced here can be seen with commit
â70d0d1f8c0615fd3b0e6484b7818bb5d14b089b3â. For every single bit there I
can provide you an explanation, for the other code introduced with
â92b99714a03c238bcda6ac0c7a57b44cf4890e65â I sadly cannot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
