Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1450#issuecomment-200825346
It is always great to see parts of a bigger method being extracted to
smaller ones, and then test cases and java docs being used.
I believe the tests like you did are ok, I would only add another assert
there as I pointed out at line 67 of the test class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
