Github user insom commented on the pull request:
https://github.com/apache/cloudstack/pull/1451#issuecomment-201620444
@alexandrelimassantana Agreed, thanks for the review. I've added a commit
removing the prototype with the default. That has allowed me to remove that if
altogether and place it inside the `applyConfigToVR` method.
@DaanHoogland Because the original commit is about the wrong signature for
the method being used I'm not quite sure how to add tests for it. I hope that
this second commit will help as it means the compiler can enforce things.
Thanks for the review!
(Also it's Friday and I don't have a Maven install on this laptop - should
pass the CI tests, if not, I may need to come back to it on Tuesday).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
