Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-202163598
Hi @prashanthvarma.
How about to use String.format() to create the strings in the loggers? The
use of String format will turn the strings in the logs more legible.
Also, at line 344, could you use Collection.isEmpty(internalLbVms) instead
of "internalLbVms == null || internalLbVms.isEmpty()" ?
Ty.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
