Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-205554379
Pretty clever the way you named the test methods, I liked it.
Just another thing.
The method "throwSshExceptionIfSshConnectionIsNull" you are testing has a
"Thread.sleep(WAITING_OPEN_SSH_SESSION)", what about using PowerMockito, so
tests do no need to wait that amount of time to execute the test per se.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
