[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

[rafaelweingartner]

Github user rafaelweingartner commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1365#discussion_r58780261
  
    --- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
    @@ -4729,6 +4729,17 @@ private VirtualMachineGuestOsIdentifier 
translateGuestOsIdentifier(String cpuArc
             return VirtualMachineGuestOsIdentifier.OTHER_GUEST;
         }
     
    +    private String translateGuestOsIdentifierEx(String cpuArchitecture, 
String guestOs, String cloudGuestOs) {
    +        if (cloudGuestOs != null) {
    +            GuestOsDescriptorType guestOsId = 
GuestOsDescriptorType.fromValue(cloudGuestOs);
    +            if (guestOsId != null) {
    +                s_logger.debug("Found guest OS mapping name for guest os: 
" + guestOs);
    --- End diff --
    
    I agree with the log message. However, I believe that adding the 
“isDebugEnabled()” would not be needed. The Logger.debug will check that, 
of course, it might be a little costly, but for legibility, I would let it as 
it is.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---