Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1466#discussion_r59146860 --- Diff: setup/db/db/schema-481to490.sql --- @@ -413,3 +413,89 @@ VIEW `user_vm_view` AS -- Add cluster.storage.operations.exclude property INSERT INTO `cloud`.`configuration` (`category`, `instance`, `component`, `name`, `description`, `default_value`, `updated`, `scope`, `is_dynamic`) VALUES ('Advanced', 'DEFAULT', 'CapacityManager', 'cluster.storage.operations.exclude', 'Exclude cluster from storage operations', 'false', now(), 'Cluster', '1'); + +-- Added in CLOUDSTACK-9340: General DB optimization, 4 cases: + +----- 1) Incorrect PRIMARY key +ALTER TABLE `cloud`.`ovs_tunnel_network` +DROP PRIMARY KEY, +ADD PRIMARY KEY (`id`), +DROP INDEX `id` , +ADD UNIQUE INDEX `i_to_from_network_id` (`to` ASC, `from` ASC, `network_id` ASC); + +----- 2) Duplicate PRIMARY KEY +ALTER TABLE `cloud`.`user_vm` DROP INDEX `id_2` ,DROP INDEX `id` ; --- End diff -- Here you remove duplicated primary keys. You are removing indexes and not primary keys per se, right? I see you removing two indexes, does that mean that the table has another one? A third one? Because if you remove the ID field index, if we use a select by that field, it would cause a full table scan, right?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---