Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-208120039 @jburwell Unfortunately Google's ImmutableMap doesn't support null for a value (which we use). I noticed this while running regression tests and googled to see if there is a way around it. Google suggested using an unmodifiableMap, but it doesn't provide the same benefits (we wouldn't be making a copying of the underlying data). It does allow you to provide back to callers a read-only implementation, though. I could allows iterate over the passed-in list and only add to the ImmutableMap entries that don't have null for a value. Not super elegant, but it would work.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---