Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1470#discussion_r59294640
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/facade/AbstractConfigItemFacade.java
---
@@ -104,13 +109,25 @@ public static AbstractConfigItemFacade
getInstance(final Class<? extends Network
return instance;
}
+
+ private static String appendUuidToJsonFiles(final String filename) {
+ String remoteFileName = new String(filename);
--- End diff --
Use of ``new String()`` is a significant performance problem as it bypasses
the constant pool -- placing additional pressure on the heap and garbage
collector. The ``StringBuilder`` class is provided for these types of
circumstances and avoids these performance problems.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
