Github user bvbharatk commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/837#discussion_r60530964
--- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java ---
@@ -1148,15 +1148,16 @@ public Host cancelMaintenance(final
CancelMaintenanceCmd cmd) {
}
@Override
- public Host reconnectHost(final ReconnectHostCmd cmd) {
- final Long hostId = cmd.getId();
+ public Host reconnectHost(ReconnectHostCmd cmd) throws
CloudRuntimeException, AgentUnavailableException{
--- End diff --
@rodrigo93
The scope of this pr is to improve the exception handling and error
messaging. Changing the method signature is not a immediate concern. I will
make the suggested changes in another pr if i find time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
