Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-214707925
>>Consider this an admin creates a read-only admin role and accounts with
that (such users can only do list* calls), now if they go back to
static-checker all such users now become default root admin (based on account
type, translation) and can call all APIs defined in commands.properties -- this
is a significant security risk. Therefore, I personally don't want to put users
at risk and just discourage them using the static checker.
@rhtyd This is what I would ideally like to see. If the user doesn't want
the dynamic roles for whatever reason he shouldn't be forced to use it. There
should be a one time choice given to users if they want to use dynamic roles.
If user decides to go ahead with it, do the data migration and there shouldn't
be an option to come back to static checker (for the reasons you have rightly
mentioned). But if user wants to continue with static checker, it should
continue to work on the basis of commands.properties.
The current way you have implemented it using global config is confusing.
Especially when you say that simply disabling the flag won't fall back to the
static checker automatically and additional stuff needs to be done to make it
work.
Let me know what you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
