Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-216307184
@swill,
I did a review on the comments and discussions to get me up to date (we had
a discussion about some code duplications). Those discussions were pretty good,
I believe that there was some block of code being repeated, and also some
blocks (or lines I do not recall) that were never used or not needed.
I did a code walkthrough and I cannot say anything about the code. It is
very good now. I can for sure give an LGMT here ;)
Sorry guys to say this, but, those discussions were not merely about
cosmetics!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
