Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r62282499
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -74,8 +79,9 @@ public void parse(byte[] vmdkFileContent) throws
IOException {
}
}
} finally {
- if (in != null)
+ if (in != null) {
--- End diff --
While I know it not in scope of the PR, would it be possible to convert the
```try``` block into a try with resources? It would remove the need for this
``finally`` clause.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
