Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1533#discussion_r62329185
--- Diff: scripts/vm/hypervisor/kvm/test_patchviasocket.py ---
@@ -0,0 +1,142 @@
+#!/usr/bin/env python
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import patchviasocket
+
+import getpass
+import os
+import socket
+import tempfile
+import time
+import threading
+import unittest
+
+KEY_DATA = "I luv\nCloudStack\n"
+CMD_DATA = "/run/this-for-me --please=TRUE! very%quickly"
+NON_EXISTING_FILE = "must-not-exist"
+
+
+def write_key_file():
+ tmpfile = tempfile.mktemp(".sck")
+ with open(tmpfile, "w") as f:
+ f.write(KEY_DATA)
+ return tmpfile
+
+
+class SocketThread(threading.Thread):
+ def __init__(self):
+ super(SocketThread, self).__init__()
+ self._data = ""
+ self._file = tempfile.mktemp(".sck")
+ self._ready = False
+
+ def data(self):
+ return self._data
+
+ def file(self):
+ return self._file
+
+ def wait_until_ready(self):
+ while not self._ready:
+ time.sleep(0.050)
+
+ def run(self):
+ TIMEOUT = 0.314 # Very short time for tests that don't write
to socket.
+ MAX_SIZE = 10 * 1024
+
+ s = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
+ s.bind(self._file)
+ s.listen(1)
+ s.settimeout(TIMEOUT)
+ try:
+ self._ready = True
+ client, address = s.accept()
+ self._data = client.recv(MAX_SIZE)
+ client.close()
+ except socket.timeout:
+ pass
+ s.close()
+ os.remove(self._file)
--- End diff --
Line 73-74 should be in a ``finally`` block to ensure the resources are
properly closed when an exception occurs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
