GitHub user rhtyd opened a pull request:
https://github.com/apache/cloudstack/pull/1538
NioTest: relax test counts to pass under timeout
Relaxes test count to pass under fixed test timeout (60s). With these
settings,
malicious clients can thereotically block main IO loop for a maximum of 30s
only.
Given environment specific JVM thread scheduling, with a test timeout of 60s
the test should pass. Practically, the test should pass under 2-3 seconds on
most platforms.
cc @mike-tutkowski @koushik-das @swill -- can you guys test this on OSX and
see if this works for you. Also, can you comment if you're OSX firewall
settings that may be blocking the NioServer which runs in the test as OSX by
default would block all listening processes.
To build and just run this test: mvn clean install -pl utils -Dtest=NioTest
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack nio-test-timeoutfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1538.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1538
----
commit 5858bb9f797778add0b335d716f7f57e0df78183
Author: Rohit Yadav <[email protected]>
Date: 2016-05-11T09:31:11Z
NioTest: relax test counts to pass under timeout
Relaxes test count to pass under fixed test timeout (60s). With these
settings,
malicious clients can thereotically block main IO loop for a maximum of 30s
only.
Given environment specific JVM thread scheduling, with a test timeout of 60s
the test should pass. Practically, the test should pass under 2-3 seconds on
most platforms.
Signed-off-by: Rohit Yadav <[email protected]>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
