GitHub user marcaurele reopened a pull request:
https://github.com/apache/cloudstack/pull/1532
DAO: Hit the cache for entity flagged as removed too
I came along this part of the code and I don't see any reason why the cache
should not be used when fetching with the "removed" ones. It will help decrease
the number of DB queries.
*It can be merged in many CS versions*
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/exoscale/cloudstack fix/db-cache-miss
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1532.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1532
----
commit 696440a6754a60888fce7a82e8022ca7278b9be5
Author: Marc-Aurèle Brothier <[email protected]>
Date: 2016-05-04T12:28:44Z
dao: Hit the cache for entity flagged as removed too since they are put
in cache afterwards.
commit 56fe0ec53dbc1331f1f4875f6f9e9bea62760c38
Author: Marc-Aurèle Brothier <[email protected]>
Date: 2016-05-09T09:39:04Z
Rewrite the change for method findByIdIncludingRemoved(ID id) and also
change the sibling method findById(final ID id)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
