Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62962859
--- Diff:
server/src/org/apache/cloudstack/network/topology/BasicNetworkVisitor.java ---
@@ -316,4 +317,9 @@ public boolean visit(final StaticRoutesRules
staticRoutesRules) throws ResourceU
public boolean visit(final AdvancedVpnRules vpnRules) throws
ResourceUnavailableException {
throw new CloudRuntimeException("AdvancedVpnRules not implemented
in Basic Network Topology.");
}
+
+ @Override
+ public boolean visit(final QuaggaRules vpnRules) throws
ResourceUnavailableException {
+ throw new CloudRuntimeException("AdvancedVpnRules not implemented
in Basic Network Topology.");
--- End diff --
CloudRuntimeException is UI friendly and is thrown to pop up the error
message on CS UI. It is also consistent with other similar methods. I think if
we find strong reasons to change it we should do it for all the other similar
methods too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
