Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1557#issuecomment-221028275
@rodrigo93,
I was reviewing your PR, nice work; but, I think you can remove some other
lines too.
I checked and the variable âs_sleepOnError â is never used. I mean, it
is used at lines 68 and 70; but, that is all (just logging). Also, that
property âsleep.interval.on.errorâ from which a new value is assigned to
âs_sleepOnError â is never referenced anywhere else. Therefore, the
âs_sleepOnError â variable can be removed, and the code from lines 60 â
76 can also be removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
