GitHub user leprechau opened a pull request:
https://github.com/apache/cloudstack/pull/1608
Upstream/context cleanup
We noticed that when an exception occurs within the cleanup loop inside
the deletePhysicalDisk routine that the previously allocated contexts
are not cleaned up. This seemed to cause an eventual crash of the host
agent after multiple exceptions within the loop.
In addition to ensuring the contexts are always freed we also improved
the logging when exceptions do occur to include the actual return code
from the underlying library in deletePhysicalDisk and deleteSnapshot.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/myENA/cloudstack upstream/context-cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1608.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1608
----
commit f0ed8b82d1da24ff1a2aa44ec102345e2131d0c8
Author: Simon Weller <[email protected]>
Date: 2016-03-24T19:45:09Z
Merge pull request #3 from apache/master
Rebase
commit fd9e0e434ca3849407e3958a7aadfa7e5ff1fe3d
Author: Simon Weller <[email protected]>
Date: 2016-04-04T14:29:03Z
Merge pull request #5 from apache/master
Update from ACS
commit 295c4e223ab449c093822b5f0d9b4d4b040f4752
Author: Simon Weller <[email protected]>
Date: 2016-04-12T19:55:44Z
Merge pull request #6 from apache/master
Merge from ACS master
commit 3f85da5d0e174722c44b87a99f0a8d2fe57cd4df
Author: Aaron Hurt <[email protected]>
Date: 2016-04-26T18:42:34Z
Merge remote-tracking branch 'upstream/master'
commit 658dcf1d07a751a6ad918d6f48c85ee5e76a4ad8
Author: Nathan Johnson <[email protected]>
Date: 2016-04-29T03:34:54Z
Merge remote-tracking branch 'upstream/master'
commit 2b49122a33379274f38a3cd1db755f655206cbb1
Author: Aaron Hurt <[email protected]>
Date: 2016-05-06T17:53:14Z
Merge remote-tracking branch 'upstream/master'
commit 36ad63d53e3e0eab8fed91c08f9b3f4dbc5c5d13
Author: Nathan Johnson <[email protected]>
Date: 2016-05-07T17:21:35Z
Merge remote-tracking branch 'upstream/master'
commit f8791b8374a3a9387473a6f8f45371801668432b
Author: David Mabry <[email protected]>
Date: 2016-06-13T17:13:28Z
Merge remote-tracking branch 'upstream/master'
commit afbe52ea634578037087a4afce4bb5a993a88b69
Author: Aaron Hurt <[email protected]>
Date: 2016-06-28T16:19:53Z
Merge remote-tracking branch 'upstream/master'
commit ab3e7f12358e261c9b8f4733c2bde837c5edff12
Author: Aaron Hurt <[email protected]>
Date: 2016-07-05T21:20:35Z
Merge remote-tracking branch 'upstream/master'
commit be5f99fc0015e80a7d42b0186396759744e858e2
Author: Aaron Hurt <[email protected]>
Date: 2016-07-09T03:57:06Z
Cleanup rbd contexts and improve exception logging
We noticed that when an exception occurs within the cleanup loop inside
the deletePhysicalDisk routine that the previously allocated contexts
are not cleaned up. This seemed to cause an eventual crash of the host
agent after multiple exceptions within the loop.
In addition to ensuring the contexts are always freed we also improved
the logging when exceptions do occur to include the actual return code
from the underlying library in deletePhysicalDisk and deleteSnapshot.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
